From 4a0d85f51ab9b07391a361b0c0623bccbd06adc1 Mon Sep 17 00:00:00 2001
From: Omar Ahmad <omar.ahmad@cis.ntt.com>
Date: Thu, 15 Aug 2019 10:52:20 -0400
Subject: [PATCH 1/7] Adding python conversion for TOML and YAML; slightly more
 verbose syntax for dockerargs

---
 Dockerfile        |  2 +-
 config.toml       | 49 +++++++++++++++++++++++++++++++++++++++++++++++
 config.yml        |  0
 docker-entrypoint | 34 ++++++++++++++++++++++++++++++--
 4 files changed, 82 insertions(+), 3 deletions(-)
 create mode 100644 config.toml
 create mode 100644 config.yml

diff --git a/Dockerfile b/Dockerfile
index e0e3a43..1ca978c 100644
--- a/Dockerfile
+++ b/Dockerfile
@@ -1,7 +1,7 @@
 FROM library/docker:stable
 
 ENV HOME_DIR=/opt/crontab
-RUN apk add --no-cache --virtual .run-deps gettext bash jq \
+RUN apk add --no-cache --virtual .run-deps gettext bash py3-toml py3-yaml python3 jq \
     && mkdir -p ${HOME_DIR}/jobs ${HOME_DIR}/projects \
     && adduser -S docker -D
 
diff --git a/config.toml b/config.toml
new file mode 100644
index 0000000..ee05c03
--- /dev/null
+++ b/config.toml
@@ -0,0 +1,49 @@
+["cron with triggered commands"]
+comment = "cron with triggered commands"
+schedule = "* * * * *"
+command = "echo hello"
+project = "crontab"
+container = "myapp"
+[["cron with triggered commands".trigger]]
+command = "echo world"
+container = "crontab_myapp_1"
+
+["map a volume"]
+comment = "map a volume"
+schedule = "* * * * *"
+dockerargs = "-d -v /tmp:/tmp"
+command = "echo new"
+image = "alpine:3.5"
+
+["use an ENV from inside a container"]
+comment = "use an ENV from inside a container"
+schedule = "@hourly"
+dockerargs = "-d -e FOO=BAR"
+command = "sh -c 'echo hourly ${FOO}'"
+image = "alpine:3.5"
+
+["trigger every 2 min"]
+comment = "trigger every 2 min"
+schedule = "@every 2m"
+command = "echo 2 minute"
+image = "alpine:3.5"
+[["trigger every 2 min".trigger]]
+command = "echo world"
+container = "crontab_myapp_1"
+
+["? /usr/sbin/logrotate /etc/logrotate.conf*/5 * * * *"]
+schedule = "*/5 * * * *"
+command = "/usr/sbin/logrotate /etc/logrotate.conf"
+
+["Regenerate Certificate then reload nginx"]
+comment = "Regenerate Certificate then reload nginx"
+schedule = "43 6,18 * * *"
+command = "sh -c 'dehydrated --cron --out /etc/ssl --domain ${LE_DOMAIN} --challenge dns-01 --hook dehydrated-dns'"
+dockerargs = "--env-file /opt/crontab/env/letsencrypt.env -v ${PWD}:/etc/ssl -v webapp_nginx_acme_challenge:/var/www/.well-known/acme-challenge"
+image = "willfarrell/letsencrypt"
+onstart = true
+[["Regenerate Certificate then reload nginx".trigger]]
+command = "sh -c '/etc/scripts/make_hpkp ${NGINX_DOMAIN} && /usr/sbin/nginx -t && /usr/sbin/nginx -s reload'"
+project = "conduit"
+container = "nginx"
+
diff --git a/config.yml b/config.yml
new file mode 100644
index 0000000..e69de29
diff --git a/docker-entrypoint b/docker-entrypoint
index 40bb622..2ce5c01 100755
--- a/docker-entrypoint
+++ b/docker-entrypoint
@@ -15,7 +15,21 @@ if [ "${LOG_FILE}" == "" ]; then
     touch ${LOG_FILE}
 fi
 
-CONFIG=${HOME_DIR}/config.json
+
+if [ -f "${HOME_DIR}/config.toml" ]; then
+    python3 -c "with open('${HOME_DIR}/config.toml') as ct, open('${HOME_DIR}/config.json', 'w') as cj: import toml; import json; json.dump(list(toml.load(ct).values()), cj)"
+elif [ -f "${HOME_DIR}/config.yml" ]; then
+    python3 -c "with open('${HOME_DIR}/config.yml') as cy, open('${HOME_DIR}/config.json', 'w') as cj: import yaml; import json; json.dump(list(yaml.safe_load(cy).values()), cj)"
+elif [ -f "${HOME_DIR}/config.yaml" ]; then
+    python3 -c "with open('${HOME_DIR}/config.yaml') as cy, open('${HOME_DIR}/config.json', 'w') as cj: import yaml; import json; json.dump(list(yaml.safe_load(cy).values()), cj)"
+fi
+
+if [ -f "${HOME_DIR}/config.json" ]; then
+    CONFIG=${HOME_DIR}/config.json
+else
+    echo "NO CONFIG FILE FOUND"
+fi
+
 DOCKER_SOCK=/var/run/docker.sock
 CRONTAB_FILE=/etc/crontabs/docker
 
@@ -49,7 +63,22 @@ slugify() {
 
 make_image_cmd() {
     DOCKERARGS=$(echo ${1} | jq -r .dockerargs)
+    VOLUMES=$(echo ${1} | jq -r '.volumes | map(" -v " + .) | join("")')
+    PORTS=$(echo ${1} | jq -r '.ports | map(" -p " + .) | join("")')
+    EXPOSE=$(echo ${1} | jq -r '.expose | map(" --expose " + .) | join("")')
+    # We'll add name in, if it exists
+    NAME=$(echo ${1} | jq -r 'select(.name != null) | .name')
+    NETWORK=$(echo ${1} | jq -r 'select(.network != null) | .network')
+    ENVIRONMENT=$(echo ${1} | jq -r '.environment | map(" -e " + .) | join("")')
+    # echo ${1} | jq -r '.environment | join("\n")' > ${PWD}/${NAME}.env
+    # ENVIRONMENT=" --env-file ${PWD}/${NAME}.env"
     if [ "${DOCKERARGS}" == "null" ]; then DOCKERARGS=; fi
+    if [ ! -z "${NAME}" ]; then DOCKERARGS="${DOCKERARGS} --rm --name ${NAME} "; fi
+    if [ ! -z "${NETWORK}" ]; then DOCKERARGS="${DOCKERARGS} --network ${NETWORK} "; fi
+    if [ ! -z "${VOLUMES}" ]; then DOCKERARGS="${DOCKERARGS}${VOLUMES}"; fi
+    if [ ! -z "${ENVIRONMENT}" ]; then DOCKERARGS="${DOCKERARGS}${ENVIRONMENT}"; fi
+    if [ ! -z "${PORTS}" ]; then DOCKERARGS="${DOCKERARGS}${PORTS}"; fi
+    if [ ! -z "${EXPOSE}" ]; then DOCKERARGS="${DOCKERARGS}${EXPOSE}"; fi
     IMAGE=$(echo ${1} | jq -r .image | envsubst)
     TMP_COMMAND=$(echo ${1} | jq -r .command)
     echo "docker run ${DOCKERARGS} ${IMAGE} ${TMP_COMMAND}"
@@ -80,6 +109,7 @@ for CONTAINER_NAME in \$CONTAINERS; do
 done
 EOF
         echo "/bin/bash ${HOME_DIR}/projects/${SCRIPT_NAME}.sh"
+        # cat "/bin/bash ${HOME_DIR}/projects/${SCRIPT_NAME}.sh"
     else
         echo "docker exec ${DOCKERARGS} ${CONTAINER} ${TMP_COMMAND}"
     fi
@@ -236,7 +266,7 @@ if [ "$1" = "crond" ]; then
     if [ -f ${CONFIG} ]; then
         build_crontab
     else
-        echo "Unable to find ${HOME_DIR}/config.json"
+        echo "Unable to find ${CONFIG}"
     fi
 fi
 

From 4f9146b8f8fe22923beac43ad8be51b46a6febd5 Mon Sep 17 00:00:00 2001
From: Omar Ahmad <omar.ahmad@cis.ntt.com>
Date: Tue, 3 Sep 2019 13:15:31 -0400
Subject: [PATCH 2/7] using tini, functions for most code in entrypoint

---
 Dockerfile        |  4 ++--
 docker-entrypoint | 48 ++++++++++++++++++++++++++---------------------
 2 files changed, 29 insertions(+), 23 deletions(-)

diff --git a/Dockerfile b/Dockerfile
index 1ca978c..a16b7cf 100644
--- a/Dockerfile
+++ b/Dockerfile
@@ -1,12 +1,12 @@
 FROM library/docker:stable
 
 ENV HOME_DIR=/opt/crontab
-RUN apk add --no-cache --virtual .run-deps gettext bash py3-toml py3-yaml python3 jq \
+RUN apk add --no-cache --virtual .run-deps gettext bash py3-toml py3-yaml python3 jq tini \
     && mkdir -p ${HOME_DIR}/jobs ${HOME_DIR}/projects \
     && adduser -S docker -D
 
 COPY docker-entrypoint /
-ENTRYPOINT ["/docker-entrypoint"]
+ENTRYPOINT ["/sbin/tini", "--", "/docker-entrypoint"]
 
 HEALTHCHECK --interval=5s --timeout=3s \
     CMD ps aux | grep '[c]rond' || exit 1
diff --git a/docker-entrypoint b/docker-entrypoint
index 2ce5c01..bb4a752 100755
--- a/docker-entrypoint
+++ b/docker-entrypoint
@@ -15,20 +15,15 @@ if [ "${LOG_FILE}" == "" ]; then
     touch ${LOG_FILE}
 fi
 
-
-if [ -f "${HOME_DIR}/config.toml" ]; then
-    python3 -c "with open('${HOME_DIR}/config.toml') as ct, open('${HOME_DIR}/config.json', 'w') as cj: import toml; import json; json.dump(list(toml.load(ct).values()), cj)"
-elif [ -f "${HOME_DIR}/config.yml" ]; then
-    python3 -c "with open('${HOME_DIR}/config.yml') as cy, open('${HOME_DIR}/config.json', 'w') as cj: import yaml; import json; json.dump(list(yaml.safe_load(cy).values()), cj)"
-elif [ -f "${HOME_DIR}/config.yaml" ]; then
-    python3 -c "with open('${HOME_DIR}/config.yaml') as cy, open('${HOME_DIR}/config.json', 'w') as cj: import yaml; import json; json.dump(list(yaml.safe_load(cy).values()), cj)"
-fi
-
-if [ -f "${HOME_DIR}/config.json" ]; then
-    CONFIG=${HOME_DIR}/config.json
-else
-    echo "NO CONFIG FILE FOUND"
-fi
+get_config() {
+    if [ -f "${HOME_DIR}/config.toml" ]; then
+        python3 -c "with open('${HOME_DIR}/config.toml') as ct, open('${HOME_DIR}/config.json', 'w') as cj: import toml; import json; json.dump(list(toml.load(ct).values()), cj)"
+    elif [ -f "${HOME_DIR}/config.yml" ]; then
+        python3 -c "with open('${HOME_DIR}/config.yml') as cy, open('${HOME_DIR}/config.json', 'w') as cj: import yaml; import json; json.dump(list(yaml.safe_load(cy).values()), cj)"
+    elif [ -f "${HOME_DIR}/config.yaml" ]; then
+        python3 -c "with open('${HOME_DIR}/config.yaml') as cy, open('${HOME_DIR}/config.json', 'w') as cj: import yaml; import json; json.dump(list(yaml.safe_load(cy).values()), cj)"
+    fi
+}
 
 DOCKER_SOCK=/var/run/docker.sock
 CRONTAB_FILE=/etc/crontabs/docker
@@ -183,6 +178,7 @@ parse_schedule() {
 }
 
 function build_crontab() {
+        
     rm -rf ${CRONTAB_FILE}
 
     ONSTART=()
@@ -260,15 +256,25 @@ EOF
     done
 }
 
+
 ensure_docker_socket_accessible
 
-if [ "$1" = "crond" ]; then
-    if [ -f ${CONFIG} ]; then
-        build_crontab
+start_app() {
+    get_config
+    if [ -f "${HOME_DIR}/config.json" ]; then
+        export CONFIG=${HOME_DIR}/config.json
     else
-        echo "Unable to find ${CONFIG}"
+        echo "NO CONFIG FILE FOUND"
     fi
-fi
+    if [ "$1" = "crond" ]; then
+        if [ -f ${CONFIG} ]; then
+            build_crontab
+        else
+            echo "Unable to find ${CONFIG}"
+        fi
+    fi
+    echo "$@"
+    exec "$@"
+}
 
-echo "$@"
-exec "$@"
+start_app "$@"

From 5013ecbc3fa92d25b8433bbc1452942517d70e27 Mon Sep 17 00:00:00 2001
From: Omar Ahmad <omar.ahmad@cis.ntt.com>
Date: Fri, 13 Sep 2019 16:25:07 -0400
Subject: [PATCH 3/7] Adding vscode to gitignore

---
 .gitignore | 1 +
 1 file changed, 1 insertion(+)

diff --git a/.gitignore b/.gitignore
index 5fa7b48..08003b4 100644
--- a/.gitignore
+++ b/.gitignore
@@ -2,3 +2,4 @@
 *.iml
 
 config.json
+.vscode
\ No newline at end of file

From 200cd1313fb8ea7d29c6a79b22bdf14d40db1144 Mon Sep 17 00:00:00 2001
From: Omar Ahmad <omar.ahmad@cis.ntt.com>
Date: Thu, 9 Jan 2020 12:46:37 -0500
Subject: [PATCH 4/7] Adding gitignore

---
 .gitignore | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/.gitignore b/.gitignore
index 08003b4..f8a3aa0 100644
--- a/.gitignore
+++ b/.gitignore
@@ -2,4 +2,5 @@
 *.iml
 
 config.json
-.vscode
\ No newline at end of file
+.vscode
+.DS_Store

From 18e9954d74dd0f51044d4853c7729e680d609133 Mon Sep 17 00:00:00 2001
From: Omar Ahmad <omar.ahmad@cis.ntt.com>
Date: Mon, 21 Dec 2020 19:19:52 -0500
Subject: [PATCH 5/7] Using RQ to change toml and yaml to JSON, removing all
 python stuff

---
 Dockerfile         | 14 +++++++++++++-
 config.yml         | 40 ++++++++++++++++++++++++++++++++++++++++
 docker-compose.yml |  2 +-
 docker-entrypoint  |  6 +++---
 4 files changed, 57 insertions(+), 5 deletions(-)

diff --git a/Dockerfile b/Dockerfile
index a16b7cf..0685c21 100644
--- a/Dockerfile
+++ b/Dockerfile
@@ -1,7 +1,19 @@
+FROM alpine:3.12 as rq-build
+
+ENV RQ_VERSION=1.0.2
+WORKDIR /root/
+
+RUN apk --update add upx \
+    && wget https://github.com/dflemstr/rq/releases/download/v${RQ_VERSION}/rq-v${RQ_VERSION}-x86_64-unknown-linux-musl.tar.gz \
+    && tar -xvf rq-v1.0.2-x86_64-unknown-linux-musl.tar.gz \
+    && upx --brute rq
+
 FROM library/docker:stable
 
+COPY --from=rq-build /root/rq /usr/local/bin
+
 ENV HOME_DIR=/opt/crontab
-RUN apk add --no-cache --virtual .run-deps gettext bash py3-toml py3-yaml python3 jq tini \
+RUN apk add --no-cache --virtual .run-deps gettext jq bash tini \
     && mkdir -p ${HOME_DIR}/jobs ${HOME_DIR}/projects \
     && adduser -S docker -D
 
diff --git a/config.yml b/config.yml
index e69de29..7016114 100644
--- a/config.yml
+++ b/config.yml
@@ -0,0 +1,40 @@
+- command: echo hello
+  comment: cron with triggered commands
+  container: myapp
+  project: crontab
+  schedule: '* * * * *'
+  trigger:
+  - command: echo world
+    container: crontab_myapp_1
+- command: echo new
+  comment: map a volume
+  dockerargs: -d -v /tmp:/tmp
+  image: alpine:3.5
+  schedule: '* * * * *'
+- command: sh -c 'echo hourly ${FOO}'
+  comment: use an ENV from inside a container
+  dockerargs: -d -e FOO=BAR
+  image: alpine:3.5
+  schedule: '@hourly'
+- command: echo 2 minute
+  comment: trigger every 2 min
+  image: alpine:3.5
+  schedule: '@every 2m'
+  trigger:
+  - command: echo world
+    container: crontab_myapp_1
+- command: /usr/sbin/logrotate /etc/logrotate.conf
+  schedule: '*/5 * * * *'
+- command: sh -c 'dehydrated --cron --out /etc/ssl --domain ${LE_DOMAIN} --challenge
+    dns-01 --hook dehydrated-dns'
+  comment: Regenerate Certificate then reload nginx
+  dockerargs: --env-file /opt/crontab/env/letsencrypt.env -v webapp_nginx_tls_cert:/etc/ssl
+    -v webapp_nginx_acme_challenge:/var/www/.well-known/acme-challenge
+  image: willfarrell/letsencrypt
+  onstart: true
+  schedule: 43 6,18 * * *
+  trigger:
+  - command: sh -c '/etc/scripts/make_hpkp ${NGINX_DOMAIN} && /usr/sbin/nginx -t &&
+      /usr/sbin/nginx -s reload'
+    container: nginx
+    project: conduit
diff --git a/docker-compose.yml b/docker-compose.yml
index 493ec84..b0bc434 100644
--- a/docker-compose.yml
+++ b/docker-compose.yml
@@ -12,4 +12,4 @@ services:
     volumes:
      - "/var/run/docker.sock:/var/run/docker.sock:ro"
     # - "/usr/bin/docker:/usr/bin/docker:ro"
-     - "/Users/willfarrell/Development/docker/docker-crontab/config.json:/opt/crontab/config.json:rw"
+     - "${PWD}/config.json:/opt/crontab/config.json:rw"
diff --git a/docker-entrypoint b/docker-entrypoint
index bb4a752..d43d878 100755
--- a/docker-entrypoint
+++ b/docker-entrypoint
@@ -17,11 +17,11 @@ fi
 
 get_config() {
     if [ -f "${HOME_DIR}/config.toml" ]; then
-        python3 -c "with open('${HOME_DIR}/config.toml') as ct, open('${HOME_DIR}/config.json', 'w') as cj: import toml; import json; json.dump(list(toml.load(ct).values()), cj)"
+        rq -t <<< $(cat ${HOME_DIR}/config.toml) | jq 'map(.)' > ${HOME_DIR}/config.json
     elif [ -f "${HOME_DIR}/config.yml" ]; then
-        python3 -c "with open('${HOME_DIR}/config.yml') as cy, open('${HOME_DIR}/config.json', 'w') as cj: import yaml; import json; json.dump(list(yaml.safe_load(cy).values()), cj)"
+        rq -y <<< $(cat ${HOME_DIR}/config.yml) | jq 'map(.)' > ${HOME_DIR}/config.json
     elif [ -f "${HOME_DIR}/config.yaml" ]; then
-        python3 -c "with open('${HOME_DIR}/config.yaml') as cy, open('${HOME_DIR}/config.json', 'w') as cj: import yaml; import json; json.dump(list(yaml.safe_load(cy).values()), cj)"
+        rq -y <<< $(cat ${HOME_DIR}/config.yaml) | jq 'map(.)' > ${HOME_DIR}/config.json
     fi
 }
 

From 0ef54cc06bb06454a4ca30225433bff57456b2d7 Mon Sep 17 00:00:00 2001
From: Omar Ahmad <omar.ahmad@cis.ntt.com>
Date: Wed, 23 Dec 2020 13:08:05 -0500
Subject: [PATCH 6/7] Updating README, adding JSON mapping support for
 consistency

---
 README.md                                     |  7 ++-
 config-samples/config.sample.json             | 60 +++++++++++++++++++
 config-samples/config.sample.mapping.json     | 60 +++++++++++++++++++
 config-samples/config.sample.mapping.yml      | 46 ++++++++++++++
 .../config.sample.toml                        |  1 +
 .../config.sample.yml                         |  0
 config.sample.json                            | 47 ---------------
 docker-compose.yml                            |  3 +-
 docker-entrypoint                             |  6 +-
 9 files changed, 178 insertions(+), 52 deletions(-)
 create mode 100644 config-samples/config.sample.json
 create mode 100644 config-samples/config.sample.mapping.json
 create mode 100644 config-samples/config.sample.mapping.yml
 rename config.toml => config-samples/config.sample.toml (95%)
 rename config.yml => config-samples/config.sample.yml (100%)
 delete mode 100644 config.sample.json

diff --git a/README.md b/README.md
index 776149b..ea25f8e 100644
--- a/README.md
+++ b/README.md
@@ -21,7 +21,10 @@ A great project, don't get me wrong. It was just missing certain key enterprise
 - Run command on a instances of a scaled container using `project`.
 - Ability to trigger scripts in other containers on completion cron job using `trigger`.
 
-## Config.json
+## Config file
+
+The config file can be specifed in any of `json`, `toml`, or `yaml`, and can be defined as either an array or mapping (top-level keys will be ignored; can be useful for organizing commands)
+
 - `name`: Human readable name that will be used as the job filename. Will be converted into a slug. Optional.
 - `comment`: Comments to be included with crontab entry. Optional.
 - `schedule`: Crontab schedule syntax as described in https://en.wikipedia.org/wiki/Cron. Ex `@hourly`, `@every 1h30m`, `* * * * *`. Required.
@@ -33,7 +36,7 @@ A great project, don't get me wrong. It was just missing certain key enterprise
 - `trigger`: Array of docker-crontab subset objects. Subset includes: `image`,`project`,`container`,`command`,`dockerargs` 
 - `onstart`: Run the command on `crontab` container start, set to `true`. Optional, defaults to falsey.
 
-See [`config.sample.json`](https://github.com/willfarrell/docker-crontab/blob/master/config.sample.json) for examples.
+See [`config-samples`](config-samples) for examples.
 
 ```json
 [{
diff --git a/config-samples/config.sample.json b/config-samples/config.sample.json
new file mode 100644
index 0000000..9716937
--- /dev/null
+++ b/config-samples/config.sample.json
@@ -0,0 +1,60 @@
+[
+  {
+    "comment": "cron with triggered commands",
+    "schedule": "* * * * *",
+    "command": "echo hello",
+    "project": "crontab",
+    "container": "myapp",
+    "trigger": [
+      {
+        "command": "echo world",
+        "container": "crontab_myapp_1"
+      }
+    ]
+  },
+  {
+    "comment": "map a volume",
+    "schedule": "* * * * *",
+    "dockerargs": "-d -v /tmp:/tmp",
+    "command": "echo new",
+    "image": "alpine:3.5"
+  },
+  {
+    "comment": "use an ENV from inside a container",
+    "schedule": "@hourly",
+    "dockerargs": "-d -e FOO=BAR",
+    "command": "sh -c 'echo hourly ${FOO}'",
+    "image": "alpine:3.5"
+  },
+  {
+    "comment": "trigger every 2 min",
+    "schedule": "@every 2m",
+    "command": "echo 2 minute",
+    "image": "alpine:3.5",
+    "trigger": [
+      {
+        "command": "echo world",
+        "container": "crontab_myapp_1"
+      }
+    ]
+  },
+  {
+    "schedule": "*/5 * * * *",
+    "command": "/usr/sbin/logrotate /etc/logrotate.conf"
+  },
+  {
+    "comment": "Regenerate Certificate then reload nginx",
+    "schedule": "43 6,18 * * *",
+    "command": "sh -c 'dehydrated --cron --out /etc/ssl --domain ${LE_DOMAIN} --challenge dns-01 --hook dehydrated-dns'",
+    "dockerargs": "--env-file /opt/crontab/env/letsencrypt.env -v webapp_nginx_tls_cert:/etc/ssl -v webapp_nginx_acme_challenge:/var/www/.well-known/acme-challenge",
+    "image": "willfarrell/letsencrypt",
+    "trigger": [
+      {
+        "command": "sh -c '/etc/scripts/make_hpkp ${NGINX_DOMAIN} && /usr/sbin/nginx -t && /usr/sbin/nginx -s reload'",
+        "project": "conduit",
+        "container": "nginx"
+      }
+    ],
+    "onstart": true
+  }
+]
diff --git a/config-samples/config.sample.mapping.json b/config-samples/config.sample.mapping.json
new file mode 100644
index 0000000..9716937
--- /dev/null
+++ b/config-samples/config.sample.mapping.json
@@ -0,0 +1,60 @@
+[
+  {
+    "comment": "cron with triggered commands",
+    "schedule": "* * * * *",
+    "command": "echo hello",
+    "project": "crontab",
+    "container": "myapp",
+    "trigger": [
+      {
+        "command": "echo world",
+        "container": "crontab_myapp_1"
+      }
+    ]
+  },
+  {
+    "comment": "map a volume",
+    "schedule": "* * * * *",
+    "dockerargs": "-d -v /tmp:/tmp",
+    "command": "echo new",
+    "image": "alpine:3.5"
+  },
+  {
+    "comment": "use an ENV from inside a container",
+    "schedule": "@hourly",
+    "dockerargs": "-d -e FOO=BAR",
+    "command": "sh -c 'echo hourly ${FOO}'",
+    "image": "alpine:3.5"
+  },
+  {
+    "comment": "trigger every 2 min",
+    "schedule": "@every 2m",
+    "command": "echo 2 minute",
+    "image": "alpine:3.5",
+    "trigger": [
+      {
+        "command": "echo world",
+        "container": "crontab_myapp_1"
+      }
+    ]
+  },
+  {
+    "schedule": "*/5 * * * *",
+    "command": "/usr/sbin/logrotate /etc/logrotate.conf"
+  },
+  {
+    "comment": "Regenerate Certificate then reload nginx",
+    "schedule": "43 6,18 * * *",
+    "command": "sh -c 'dehydrated --cron --out /etc/ssl --domain ${LE_DOMAIN} --challenge dns-01 --hook dehydrated-dns'",
+    "dockerargs": "--env-file /opt/crontab/env/letsencrypt.env -v webapp_nginx_tls_cert:/etc/ssl -v webapp_nginx_acme_challenge:/var/www/.well-known/acme-challenge",
+    "image": "willfarrell/letsencrypt",
+    "trigger": [
+      {
+        "command": "sh -c '/etc/scripts/make_hpkp ${NGINX_DOMAIN} && /usr/sbin/nginx -t && /usr/sbin/nginx -s reload'",
+        "project": "conduit",
+        "container": "nginx"
+      }
+    ],
+    "onstart": true
+  }
+]
diff --git a/config-samples/config.sample.mapping.yml b/config-samples/config.sample.mapping.yml
new file mode 100644
index 0000000..e043837
--- /dev/null
+++ b/config-samples/config.sample.mapping.yml
@@ -0,0 +1,46 @@
+cron with triggered commands:
+  command: echo hello
+  comment: cron with triggered commands
+  container: myapp
+  project: crontab
+  schedule: '* * * * *'
+  trigger:
+  - command: echo world
+    container: crontab_myapp_1
+map a volume:
+  command: echo new
+  comment: map a volume
+  dockerargs: -d -v /tmp:/tmp
+  image: alpine:3.5
+  schedule: '* * * * *'
+use an ENV from inside a container:
+  command: sh -c 'echo hourly ${FOO}'
+  comment: use an ENV from inside a container
+  dockerargs: -d -e FOO=BAR
+  image: alpine:3.5
+  schedule: '@hourly'
+trigger every 2 min:
+  command: echo 2 minute
+  comment: trigger every 2 min
+  image: alpine:3.5
+  schedule: '@every 2m'
+  trigger:
+  - command: echo world
+    container: crontab_myapp_1
+null:
+  command: /usr/sbin/logrotate /etc/logrotate.conf
+  schedule: '*/5 * * * *'
+Regenerate Certificate then reload nginx:
+  command: sh -c 'dehydrated --cron --out /etc/ssl --domain ${LE_DOMAIN} --challenge
+    dns-01 --hook dehydrated-dns'
+  comment: Regenerate Certificate then reload nginx
+  dockerargs: --env-file /opt/crontab/env/letsencrypt.env -v webapp_nginx_tls_cert:/etc/ssl
+    -v webapp_nginx_acme_challenge:/var/www/.well-known/acme-challenge
+  image: willfarrell/letsencrypt
+  onstart: true
+  schedule: 43 6,18 * * *
+  trigger:
+  - command: sh -c '/etc/scripts/make_hpkp ${NGINX_DOMAIN} && /usr/sbin/nginx -t &&
+      /usr/sbin/nginx -s reload'
+    container: nginx
+    project: conduit
diff --git a/config.toml b/config-samples/config.sample.toml
similarity index 95%
rename from config.toml
rename to config-samples/config.sample.toml
index ee05c03..5320c3f 100644
--- a/config.toml
+++ b/config-samples/config.sample.toml
@@ -1,3 +1,4 @@
+# toml files can only have top-loevl mappings, so this is the only sample
 ["cron with triggered commands"]
 comment = "cron with triggered commands"
 schedule = "* * * * *"
diff --git a/config.yml b/config-samples/config.sample.yml
similarity index 100%
rename from config.yml
rename to config-samples/config.sample.yml
diff --git a/config.sample.json b/config.sample.json
deleted file mode 100644
index 6e72e00..0000000
--- a/config.sample.json
+++ /dev/null
@@ -1,47 +0,0 @@
-[{
-	"comment":"cron with triggered commands",
-	"schedule":"* * * * *",
-	"command":"echo hello",
-	"project":"crontab",
-	"container":"myapp",
-	"trigger":[{
-		"command":"echo world",
-		"container":"crontab_myapp_1"
-	}]
-},{
-	"comment":"map a volume",
-	"schedule":"* * * * *",
-	"dockerargs":"-d -v /tmp:/tmp",
-	"command":"echo new",
-	"image":"alpine:3.5"
-},{
-	"comment":"use an ENV from inside a container",
-	"schedule":"@hourly",
-	"dockerargs":"-d -e FOO=BAR",
-	"command":"sh -c 'echo hourly ${FOO}'",
-	"image":"alpine:3.5"
-},{
-	"comment":"trigger every 2 min",
-	"schedule":"@every 2m",
-	"command":"echo 2 minute",
-	"image":"alpine:3.5",
-	"trigger":[{
-		"command":"echo world",
-		"container":"crontab_myapp_1"
-	}]
-},{
-	"schedule":"*/5 * * * *",
-	"command":"/usr/sbin/logrotate /etc/logrotate.conf"
-},{
-	"comment":"Regenerate Certificate then reload nginx",
-	"schedule":"43 6,18 * * *",
-	"command":"sh -c 'dehydrated --cron --out /etc/ssl --domain ${LE_DOMAIN} --challenge dns-01 --hook dehydrated-dns'",
-	"dockerargs":"--env-file /opt/crontab/env/letsencrypt.env -v webapp_nginx_tls_cert:/etc/ssl -v webapp_nginx_acme_challenge:/var/www/.well-known/acme-challenge",
-	"image":"willfarrell/letsencrypt",
-	"trigger":[{
-		"command":"sh -c '/etc/scripts/make_hpkp ${NGINX_DOMAIN} && /usr/sbin/nginx -t && /usr/sbin/nginx -s reload'",
-		"project":"conduit",
-		"container":"nginx"
-	}],
-	"onstart":true
-}]
\ No newline at end of file
diff --git a/docker-compose.yml b/docker-compose.yml
index b0bc434..a7cf566 100644
--- a/docker-compose.yml
+++ b/docker-compose.yml
@@ -11,5 +11,4 @@ services:
     restart: always
     volumes:
      - "/var/run/docker.sock:/var/run/docker.sock:ro"
-    # - "/usr/bin/docker:/usr/bin/docker:ro"
-     - "${PWD}/config.json:/opt/crontab/config.json:rw"
+     - "${PWD}/config-samples/config.sample.mapping.json:/opt/crontab/config.json:rw"
diff --git a/docker-entrypoint b/docker-entrypoint
index d43d878..f2551bb 100755
--- a/docker-entrypoint
+++ b/docker-entrypoint
@@ -16,7 +16,11 @@ if [ "${LOG_FILE}" == "" ]; then
 fi
 
 get_config() {
-    if [ -f "${HOME_DIR}/config.toml" ]; then
+    if [ -f "${HOME_DIR}/config.json" ]; then
+        cp ${HOME_DIR}/config.json ${HOME_DIR}/config.json.old
+        jq 'map(.)' ${HOME_DIR}/config.json.old > ${HOME_DIR}/config.json
+        rm ${HOME_DIR}/config.json.old
+    elif [ -f "${HOME_DIR}/config.toml" ]; then
         rq -t <<< $(cat ${HOME_DIR}/config.toml) | jq 'map(.)' > ${HOME_DIR}/config.json
     elif [ -f "${HOME_DIR}/config.yml" ]; then
         rq -y <<< $(cat ${HOME_DIR}/config.yml) | jq 'map(.)' > ${HOME_DIR}/config.json

From 88bed2bc4ace4395e5e43fa84ea982ed2dccd738 Mon Sep 17 00:00:00 2001
From: Omar Ahmad <omar.ahmad@cis.ntt.com>
Date: Wed, 23 Dec 2020 13:22:15 -0500
Subject: [PATCH 7/7] Fixing entrypoint dealing with JSON mapping

---
 config-samples/config.sample.mapping.json | 30 ++++++++---------------
 docker-entrypoint                         | 10 ++++----
 2 files changed, 15 insertions(+), 25 deletions(-)

diff --git a/config-samples/config.sample.mapping.json b/config-samples/config.sample.mapping.json
index 9716937..3b30a2c 100644
--- a/config-samples/config.sample.mapping.json
+++ b/config-samples/config.sample.mapping.json
@@ -1,48 +1,38 @@
-[
-  {
+{
+  "cron with triggered commands": {
     "comment": "cron with triggered commands",
     "schedule": "* * * * *",
     "command": "echo hello",
     "project": "crontab",
     "container": "myapp",
-    "trigger": [
-      {
-        "command": "echo world",
-        "container": "crontab_myapp_1"
-      }
-    ]
+    "trigger": [{ "command": "echo world", "container": "crontab_myapp_1" }]
   },
-  {
+  "map a volume": {
     "comment": "map a volume",
     "schedule": "* * * * *",
     "dockerargs": "-d -v /tmp:/tmp",
     "command": "echo new",
     "image": "alpine:3.5"
   },
-  {
+  "use an ENV from inside a container": {
     "comment": "use an ENV from inside a container",
     "schedule": "@hourly",
     "dockerargs": "-d -e FOO=BAR",
     "command": "sh -c 'echo hourly ${FOO}'",
     "image": "alpine:3.5"
   },
-  {
+  "trigger every 2 min": {
     "comment": "trigger every 2 min",
     "schedule": "@every 2m",
     "command": "echo 2 minute",
     "image": "alpine:3.5",
-    "trigger": [
-      {
-        "command": "echo world",
-        "container": "crontab_myapp_1"
-      }
-    ]
+    "trigger": [{ "command": "echo world", "container": "crontab_myapp_1" }]
   },
-  {
+  "null": {
     "schedule": "*/5 * * * *",
     "command": "/usr/sbin/logrotate /etc/logrotate.conf"
   },
-  {
+  "Regenerate Certificate then reload nginx": {
     "comment": "Regenerate Certificate then reload nginx",
     "schedule": "43 6,18 * * *",
     "command": "sh -c 'dehydrated --cron --out /etc/ssl --domain ${LE_DOMAIN} --challenge dns-01 --hook dehydrated-dns'",
@@ -57,4 +47,4 @@
     ],
     "onstart": true
   }
-]
+}
diff --git a/docker-entrypoint b/docker-entrypoint
index f2551bb..2696ee5 100755
--- a/docker-entrypoint
+++ b/docker-entrypoint
@@ -17,9 +17,7 @@ fi
 
 get_config() {
     if [ -f "${HOME_DIR}/config.json" ]; then
-        cp ${HOME_DIR}/config.json ${HOME_DIR}/config.json.old
-        jq 'map(.)' ${HOME_DIR}/config.json.old > ${HOME_DIR}/config.json
-        rm ${HOME_DIR}/config.json.old
+        jq 'map(.)' ${HOME_DIR}/config.json > ${HOME_DIR}/config.working.json
     elif [ -f "${HOME_DIR}/config.toml" ]; then
         rq -t <<< $(cat ${HOME_DIR}/config.toml) | jq 'map(.)' > ${HOME_DIR}/config.json
     elif [ -f "${HOME_DIR}/config.yml" ]; then
@@ -265,8 +263,10 @@ ensure_docker_socket_accessible
 
 start_app() {
     get_config
-    if [ -f "${HOME_DIR}/config.json" ]; then
-        export CONFIG=${HOME_DIR}/config.json
+    if [ -f "${HOME_DIR}/config.working.json" ]; then
+        export CONFIG=${HOME_DIR}/config.working.json
+    elif [ -f "${HOME_DIR}/config.json" ]; then
+         export CONFIG=${HOME_DIR}/config.json
     else
         echo "NO CONFIG FILE FOUND"
     fi